test: pin unknown-venue path when registry service absent - #531
Merged
Conversation
mfw78
force-pushed
the
test/510-unknown-venue-no-registry-service
branch
from
July 23, 2026 14:15
48314f7 to
0989b72
Compare
mfw78
force-pushed
the
test/510-unknown-venue-no-registry-service
branch
from
July 23, 2026 14:52
0989b72 to
a893011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add one integration test to
crates/videre-host/tests/platform.rspinning the service-lookup-missUnknownVenuepath inclient.rs, whereservices.get::<VenueRegistry>(NAMESPACE)returnsNone.A minimal
ClientWithoutRegistry(Videre)Extensionwrapper forwards every faceboot_singleconsults (namespace, capabilities, link, manifest_sections, subscriptions, admit_worker) to the realVidere, but leavesservice()at itsNonedefault, soHostServices::from_extensionsseeds no venue registry.The test
client_without_registry_service_resolves_every_venue_to_unknownboots the prebuiltecho-clientkeeper viaSupervisor::boot_singlewith a[venue]-free manifest, assertssupervisor.services().get::<VenueRegistry>(NAMESPACE).is_none()as the branch precondition, dispatches a chain-1 block, and asserts the keeper stays alive with quote and submit each resolving to unknown-venue.No production code is touched.
Why
The service-missing branch (registry service absent entirely) is distinct from the already-covered adapter-map miss (registry present, venue id merely unlisted). This test pins the former end to end, exercising the resolve-to-unknown path before any adapter is consulted.
A
[venue]-free manifest is required because a keeper declaring[venue]would be refused byadmit_workerbefore it could reach the client face, given no adapters boot underboot_single.Testing
cargo fmt --all -- --checkpasses with no diff.cargo clippy -p videre-host --all-targets --all-featuresclean aftercargo clean -p videre-host.The test has genuine teeth: seeding a real registry flips the
is_none()precondition and fails the test. CI builds theecho-clientwasm before nextest, so the test runs rather than skips.AI Assistance
Implemented, reviewed and verified with Claude Code (Opus).
Closes #510