-
Notifications
You must be signed in to change notification settings - Fork 2
sdk: land the alloy-grade dx polish cluster #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
OrderBuilder<S>typestate (three phantom marker types plus duplicatedfor_at_least/for_at_mostmethods) may be more machinery than the actual constraint needs.OrderBody's required fields (sell/buy side+amount,valid_to) are flat and mutually independent — nothing about CoW's wire format requires a specific call order, only that all required fields end up set. Typestate pays off when order-of-calls is semantically constrained (e.g. must-sign-before-submit); here it's really just "don't forget a required field," which a simplerResult-returning builder or required-args-in-constructor + optional setters would give with less API surface. Not a bug, just worth a second look at whether the complexity earns its keep.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed still present at HEAD:
OrderBuilder<S>withPhantomData, four state markers (NeedsBuy,NeedsSell,NeedsValidTo,Ready), per-state impl blocks, andbuildgated onReady. Tracked in #545 (M8).Agreed the invariant here is "do not forget a required field" rather than a genuine call-order constraint, so the state machine is expressing something stronger than the domain requires. One refinement to the alternatives: of the two you list, required-args-in-constructor plus optional setters is the one worth pursuing, because it keeps the same compile-time completeness guarantee while dropping the phantom states and the duplicated method surface. The
Result-returning builder trades that guarantee for runtime failure, which is the wrong direction for an order type where a missing required field is exactly what you want caught at compile time. #545 frames it as that choice, with "keep it and say why in the rustdoc" as the explicit third option so this does not get re-opened later.