-
Notifications
You must be signed in to change notification settings - Fork 2
sdk: guest seams and mocks for identity, messaging and remote-store #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This widening is a non-event for modules using exact trait bounds (e.g.
balance-trackerwas migrated in this same PR fromH: HosttoH: ChainHost + LocalStoreHost), butmodules/examples/price-alertwasn't migrated and still compiles — not by design, but becauseprice-alert/src/lib.rscalls the zero-argbind_host_via_wit_bindgen!()blanket-world form, which expands to all six capabilities regardless of whatmodule.tomlactually declares (required = ["logging", "chain"]). So price-alert's generatedWitBindgenHostnow silently implementsIdentityHost/MessagingHost/RemoteStoreHostcalls it has no capability grant for — declared capabilities and implemented trait surface have diverged, and nothing catches that divergence at compile time or in manifest validation. Worth routing every module through the capability-selected macro form, or adding a check that a module's declared caps match its bound trait set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superseded at HEAD. The zero-arg blanket bind is gone: modules now use the
#[nexum_sdk::module]attribute (the newnexum-module-macroscrate, macro-split car). That macro reads the crate'smodule.tomland synthesizes a per-module world whose imports are exactly the declared[capabilities].required/optional, so an undeclared capability's bindings simply do not exist. The generated host can no longer implementIdentityHost/MessagingHost/RemoteStoreHostfor a module that did not declare them, and the runtime's load-time capability check passes by construction.price-alert(required = ["logging", "chain"]) binds only those at the tip. This is exactly the "route every module through the capability-selected macro form" fix you suggested, closed at the macro level. (Independently, host-sidemanifest/capabilities.rsfail-closed-gates the surface, so even the old blanket form was enforced host-side, not an exploitable escalation.)