fix: rename the last ComposableCoW-cased test filename - #47
Open
mfw78 wants to merge 1 commit into
Open
Conversation
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 30, 2026 08:23
7bdae74 to
b569442
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 30, 2026 08:23
df7be86 to
386811e
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 30, 2026 08:42
b569442 to
7229256
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 30, 2026 08:42
386811e to
17c020d
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 30, 2026 09:51
7229256 to
fe5f94f
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 30, 2026 09:51
17c020d to
95fb1de
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 30, 2026 09:54
fe5f94f to
8182be8
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 30, 2026 09:54
95fb1de to
44e0fb7
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 30, 2026 10:24
8182be8 to
fe2cdf4
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 30, 2026 10:24
44e0fb7 to
3697732
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 30, 2026 10:40
fe2cdf4 to
34795a3
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
2 times, most recently
from
July 30, 2026 12:54
5fd82fd to
df090b8
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 30, 2026 12:54
34795a3 to
6188459
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 30, 2026 13:07
df090b8 to
bce18c0
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 30, 2026 13:07
6188459 to
5e0d504
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 30, 2026 13:19
bce18c0 to
b83424e
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
2 times, most recently
from
July 30, 2026 13:55
47f2219 to
7a7e6cf
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
2 times, most recently
from
July 30, 2026 14:25
2af8f1d to
b2e4dd0
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
2 times, most recently
from
July 30, 2026 23:43
2034f3a to
72fdc2b
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
2 times, most recently
from
July 30, 2026 23:51
5a8ff7b to
d1d1cd6
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 30, 2026 23:51
72fdc2b to
803b2f8
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 31, 2026 00:06
d1d1cd6 to
c13ad13
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 31, 2026 00:06
803b2f8 to
49bcb00
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 31, 2026 00:12
c13ad13 to
deb0a9d
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 31, 2026 00:12
49bcb00 to
c312d8d
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 31, 2026 00:14
c312d8d to
de716d6
Compare
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 31, 2026 00:14
deb0a9d to
bbd9b14
Compare
`test/ComposableCoW.t.sol` was missed by the rename in #44. The pattern used there matched `test/ComposableCoW.*.t.sol`, which requires a middle segment, so the one file without one slipped through. Its contents were renamed correctly, which is why a content search over file bodies did not catch it. Filename only: the contract inside is already `ComposableCowTest` and nothing references the path.
mfw78
force-pushed
the
fix/test-filename-casing
branch
from
July 31, 2026 04:00
bbd9b14 to
693efb9
Compare
mfw78
force-pushed
the
style/in-body-comments
branch
from
July 31, 2026 04:00
de716d6 to
0267b62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/ComposableCoW.t.solwas missed by the rename in #44, leaving it as the only remainingComposableCoW-cased filename in the tree that is not a deliberate exception.The pattern used in #44 matched
test/ComposableCoW.*.t.sol, which requires a middle segment (.base.,.twap., ...). The one file without one never matched. Its contents were renamed correctly, so a search over file bodies came back clean and the miss went unnoticed.Filename only, zero content change: the contract inside is already
ComposableCowTest, nothing references the path, and.gas-snapshotkeys off contract names rather than filenames.Remaining
ComposableCoW-cased paths after this are both deliberate:audits/gnosis-ComposableCoWMayJul2023.pdf(published artefact) andbroadcast/StandardJsonInput/ComposableCoW.json(historical deployment record).How to test
Returns only the two intentional exceptions above.
Part of #1.