Skip to content

refactor: adopt require-with-custom-error style - #30

Merged
mfw78 merged 1 commit into
developfrom
refactor/require-custom-errors
Jul 31, 2026
Merged

refactor: adopt require-with-custom-error style#30
mfw78 merged 1 commit into
developfrom
refactor/require-custom-errors

Conversation

@mfw78

@mfw78 mfw78 commented Jul 10, 2026

Copy link
Copy Markdown

Solidity >=0.8.27 supports require(condition, CustomError()) in the legacy pipeline; convert the remaining if (!(condition)) revert sites so preconditions read as preconditions. Bytecode-equivalent.

Part of #1.

@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from a43b42d to 8bcf0c3 Compare July 30, 2026 03:50
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from b668bda to 452a443 Compare July 30, 2026 03:50
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 8bcf0c3 to 63c1004 Compare July 30, 2026 04:01
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch 2 times, most recently from 51b23dd to c766366 Compare July 30, 2026 06:59
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 63c1004 to 596389a Compare July 30, 2026 06:59
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from c766366 to e66564c Compare July 30, 2026 07:02
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 596389a to 060bc48 Compare July 30, 2026 07:02
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from e66564c to ed40976 Compare July 30, 2026 07:07
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch 3 times, most recently from bf590b0 to f1eff7c Compare July 30, 2026 07:14
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch 2 times, most recently from b48ae78 to eaa61a8 Compare July 30, 2026 07:18
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from f1eff7c to 8a941c3 Compare July 30, 2026 07:18
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from eaa61a8 to e7cfeac Compare July 30, 2026 07:22
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 8a941c3 to 7a85d84 Compare July 30, 2026 07:22
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from e7cfeac to ddecfb6 Compare July 30, 2026 07:26
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 7a85d84 to 9010b24 Compare July 30, 2026 07:26
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from ddecfb6 to ed73d3d Compare July 30, 2026 07:33
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 9010b24 to 3445d39 Compare July 30, 2026 07:33
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from ed73d3d to 6554f56 Compare July 30, 2026 08:23
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 3445d39 to 130e269 Compare July 30, 2026 08:23
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from 6554f56 to d0e2a0f Compare July 30, 2026 08:42
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 130e269 to dcd05f6 Compare July 30, 2026 08:42
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from d0e2a0f to b5fb2bd Compare July 30, 2026 09:51
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch 2 times, most recently from 92be3d4 to 6cbc689 Compare July 30, 2026 09:54
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from b5fb2bd to 0e6284b Compare July 30, 2026 09:54
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from 0e6284b to be043cf Compare July 30, 2026 10:24
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch 2 times, most recently from 28428bd to c6c17be Compare July 30, 2026 10:40
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch 2 times, most recently from 538c59b to cc5a62f Compare July 30, 2026 12:54
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch 2 times, most recently from fa42396 to 78626c2 Compare July 30, 2026 13:07
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch 2 times, most recently from 515b61a to a68f7f6 Compare July 30, 2026 13:19
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 78626c2 to 84e3886 Compare July 30, 2026 13:19
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from a68f7f6 to e509b1e Compare July 30, 2026 13:55
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 84e3886 to 37f6449 Compare July 30, 2026 13:55
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch from e509b1e to 676f9e7 Compare July 30, 2026 14:25
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch 2 times, most recently from 1507d96 to ff7debc Compare July 30, 2026 23:43
@mfw78
mfw78 force-pushed the docs/dual-path-architecture branch 2 times, most recently from a452b31 to f10390c Compare July 30, 2026 23:51
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch 2 times, most recently from 4c45245 to 57dfdbc Compare July 31, 2026 00:06
Base automatically changed from docs/dual-path-architecture to develop July 31, 2026 00:11
Solidity >=0.8.27 supports require(condition, CustomError()) in the
legacy pipeline; convert the remaining if (!(condition)) revert sites
so preconditions read as preconditions. Bytecode-equivalent.
@mfw78
mfw78 force-pushed the refactor/require-custom-errors branch from 57dfdbc to b9fdc2a Compare July 31, 2026 00:12
@mfw78
mfw78 merged commit 03762d3 into develop Jul 31, 2026
@mfw78
mfw78 deleted the refactor/require-custom-errors branch July 31, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant