Misc improvements#3778
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3778 +/- ##
==========================================
+ Coverage 85.25% 85.42% +0.16%
==========================================
Files 571 571
Lines 50435 50428 -7
Branches 15291 15291
==========================================
+ Hits 43000 43078 +78
+ Misses 6802 6718 -84
+ Partials 633 632 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jotare
approved these changes
Jul 8, 2026
| if shard_id is None: | ||
| logger.warning(f"Resource {uuid} does not exist") | ||
| logger.warning( | ||
| "Resource shard not found: Skipping delete", extra={"kbid": kbid, "rid": uuid} |
Contributor
There was a problem hiding this comment.
Should we log the missing shard id too?
Comment on lines
313
to
+314
| logger.info( | ||
| "Resource does not exist: skipping txn", extra={"kbid": kbid, "slug": message.slug} | ||
| "Resource slug not found: skipping txn", extra={"kbid": kbid, "slug": message.slug} |
Contributor
There was a problem hiding this comment.
This shouldn't happen. Should it be a warning?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How was this PR tested?
Describe how you tested this PR.