Cache unchanged AI review verdicts - #36
Merged
Merged
Conversation
Contributor
Author
|
Implementation review complete: no blocking findings. Validation evidence:
Temporary smoke PR: nubster-opensources/lightshuttle#317 (closed without merge). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Team review reruns currently repeat all specialist, synthesis and lens calls even when the review input is unchanged. This adds latency and API cost, and needlessly recomputes stable per-finding verification.
Impact
Identical reruns return after the GitHub diff/comment lookup. Partial changes can reuse safe per-finding verdicts while changed context is reverified. Existing visible review formatting is unchanged because the cache is stored in an HTML comment.
Validation
cargo +1.88.0 fmt --all -- --checkcargo +1.88.0 clippy --workspace --all-targets --all-features -- -D warningscargo +1.88.0 test --workspace --all-features --no-fail-fastcargo +1.88.0 check --workspace --all-features --all-targetsCloses #11