fix(review): fail closed on incomplete coverage - #35
Merged
Conversation
Contributor
Author
|
Final smoke validation passed on lightshuttle run 31614721376 against exact SHA
The temporary PR will be closed without merge and cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
INCOMPLETEteam verdict whenever coverage gaps remain or the 15-finding verification cap leaves findings uncheckedNEEDS_WORKauthoritative when a confirmed critical finding is already knownWhy
The coverage work in #33 and #34 made every unreviewed input visible, but the global verdict could still say
SHIPafter partial coverage. Re-running a review also created duplicate inline comments, a global marker beyond GitHub's first comment page could be missed, and inline findings that disappeared on a later run remained visible.Impact
A partial review can no longer be presented as shippable. Re-runs on the same head commit converge the global and inline bot comments to the current result: existing comments are updated, new locations are created, and results no longer confirmed by that mode are removed.
Validation
cargo fmt --manifest-path tools/ai-review/Cargo.toml -- --checkcargo clippy --manifest-path tools/ai-review/Cargo.toml --all-targets -- -D warningscargo test --manifest-path tools/ai-review/Cargo.tomlMerge policy
Keep this pull request in draft until CI, the real rerun/idempotence smoke test, and review are complete. Do not merge without explicit approval.