Skip to content

Update generated client from staging OpenAPI#47

Closed
leo-notte wants to merge 3 commits into
mainfrom
release-check-openapi-refresh-20260615
Closed

Update generated client from staging OpenAPI#47
leo-notte wants to merge 3 commits into
mainfrom
release-check-openapi-refresh-20260615

Conversation

@leo-notte

Copy link
Copy Markdown
Contributor

Summary

  • regenerate Go API client from staging OpenAPI
  • includes latest generated client changes needed by release-check

Verification

  • go test -short ./...
  • make check verified in a clean temp clone with this generated patch applied

@greptile-apps

greptile-apps Bot commented Jun 15, 2026

Copy link
Copy Markdown

Greptile Summary

This PR regenerates internal/api/client.gen.go from the staging OpenAPI spec to include new endpoints and type changes needed by the upcoming release-check workflow.

  • New endpoints: Secrets management (list, store, get, delete at /secrets) and profile cookies (get/set at /profiles/{id}/cookies) with full request-builder, client, and response-parser implementations.
  • Constant renaming: SessionResponseBrowserType constants are prefixed with the type name (e.g., ChromeSessionResponseBrowserTypeChrome); a grep confirms no existing callers used the old names, so there is no breakage.
  • Model simplification: RootModelUnionDictStrAnyListDictStrAny and its union-dispatch methods are replaced by type RootModelAny = interface{}, and NotteProxy gains an optional City field.

Confidence Score: 5/5

Safe to merge — this is a mechanical OpenAPI client regeneration with no breaking changes to existing callers.

All renamed constants and removed types have no callers in the current codebase, so the regeneration is backward-compatible in practice. The new endpoints follow the same generated patterns as all existing ones, and the logic is straightforward request-building and response-parsing boilerplate.

No files require special attention; the single changed file is entirely generated code.

Important Files Changed

Filename Overview
internal/api/client.gen.go Regenerated Go API client: adds secrets CRUD + profile cookies endpoints, renames SessionResponseBrowserType constants to be type-prefixed, simplifies RootModelAny to interface{}, and adds NotteProxy.City field. No existing callers of the renamed/removed identifiers were found.

Reviews (2): Last reviewed commit: "Update generated client from staging Ope..." | Re-trigger Greptile

@leo-notte

Copy link
Copy Markdown
Contributor Author

Regenerated the Go client against an OpenAPI export from the monorepo PR branch, so secrets params no longer include period; period remains only on GET /usage.\n\nVerification run locally:\n- go test -short ./...

@leo-notte leo-notte force-pushed the release-check-openapi-refresh-20260615 branch from c2561e4 to 1784996 Compare June 15, 2026 21:42
@leo-notte

Copy link
Copy Markdown
Contributor Author

Closing because the PR is now empty and release checks indicate main is already in sync.

@leo-notte leo-notte closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant