Skip to content

Update generated CLI client from staging OpenAPI#46

Merged
leo-notte merged 1 commit into
mainfrom
codex/notte-cli-staging-openapi-27100810129
Jun 7, 2026
Merged

Update generated CLI client from staging OpenAPI#46
leo-notte merged 1 commit into
mainfrom
codex/notte-cli-staging-openapi-27100810129

Conversation

@leo-notte

Copy link
Copy Markdown
Contributor

Summary\n- Regenerate the CLI OpenAPI client against staging OpenAPI\n- Update structured data root model generation to RootModelAny\n\n## Validation\n- make check\n- go test ./...

@greptile-apps

greptile-apps Bot commented Jun 7, 2026

Copy link
Copy Markdown

Greptile Summary

This PR regenerates internal/api/client.gen.go against the updated staging OpenAPI spec, replacing the verbose RootModelUnionDictStrAnyListDictStrAny union type (a struct with six marshal/unmarshal helpers) with the simpler type alias RootModelAny = interface{}.

  • The old union type and all six associated helper methods (As*, From*, Merge*) are removed; the three corresponding methods on StructuredDataBaseModel_Data are updated to use the new alias.
  • No callers outside client.gen.go reference the old type, so there is no downstream breakage.

Confidence Score: 5/5

Safe to merge — the change is confined to a single generated file, the removed type had no callers outside the file, and the simplified alias is a faithful representation of the updated OpenAPI schema.

The diff is a mechanical code-generation update. The old union type was only referenced internally within client.gen.go, so nothing downstream breaks. The new interface{} alias correctly matches the Any schema in the updated spec, and the three surviving helper methods on StructuredDataBaseModel_Data behave identically to their predecessors for well-formed JSON.

No files require special attention.

Important Files Changed

Filename Overview
internal/api/client.gen.go Generated client update: replaces the verbose union type RootModelUnionDictStrAnyListDictStrAny (struct + 6 marshal/unmarshal helpers) with the simple type alias RootModelAny = interface{}, matching the updated staging OpenAPI spec; no callers outside this file are affected.

Fix All in Codex

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
internal/api/client.gen.go:1
**No tests added in this PR**

This PR does not include any unit or integration tests. Even for a generated client, a small round-trip test covering `AsRootModelAny` / `FromRootModelAny` on `StructuredDataBaseModel_Data` would help catch regressions if the schema changes again — especially since `RootModelAny` is now `interface{}` and `json.Unmarshal` into an untyped value can silently change the concrete Go type (e.g. numbers become `float64`) in ways that callers might not expect.
- Add a comment if the PR does n... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))

Reviews (2): Last reviewed commit: "Update generated client from staging Ope..." | Re-trigger Greptile

@leo-notte leo-notte merged commit 0f1ce0f into main Jun 7, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant