Skip to content

Update generated CLI client from staging OpenAPI#45

Merged
leo-notte merged 1 commit into
mainfrom
release-check-openapi-secrets
Jun 3, 2026
Merged

Update generated CLI client from staging OpenAPI#45
leo-notte merged 1 commit into
mainfrom
release-check-openapi-secrets

Conversation

@leo-notte

Copy link
Copy Markdown
Contributor

Summary

  • regenerate the Go CLI OpenAPI client from staging
  • include the latest profile cookies endpoints and proxy schema updates

Verification

  • make check

@leo-notte leo-notte force-pushed the release-check-openapi-secrets branch from 339b654 to be9a79b Compare June 3, 2026 00:32
@greptile-apps

greptile-apps Bot commented Jun 3, 2026

Copy link
Copy Markdown

Greptile Summary

This PR regenerates internal/api/client.gen.go from the staging OpenAPI spec, adding new endpoints and schema updates. No hand-written logic is modified.

  • Profile cookies endpoints: Adds ProfileCookiesGet and ProfileCookiesSet (GET/POST /profiles/{id}/cookies) with corresponding request/response models (ProfileCookiesImportRequest, ProfileCookiesImportResponse).
  • Secrets management endpoints: Adds ListSecrets, StoreSecret, GetSecret, and DeleteSecret with SecretMetadata, SecretListResponse, SecretStoreRequest, and SecretValueResponse models.
  • Schema updates: NotteProxy gains an optional City field; SessionResponseBrowserType constants are renamed with a type prefix (e.g., ChromeSessionResponseBrowserTypeChrome); several *Result types are renamed for consistency.

Confidence Score: 5/5

Safe to merge — the change is a pure regeneration of a generated client file with no hand-written logic.

All changes are machine-generated from the OpenAPI spec. The renamed constants and result types are not referenced outside the generated file. No existing callers are broken.

No files require special attention, though follow-up PRs implementing CLI commands for the new secrets and profile-cookies endpoints should include tests.

Important Files Changed

Filename Overview
internal/api/client.gen.go Regenerated OpenAPI client adding profile cookies (GET/SET) and secrets management (List/Get/Store/Delete) endpoints, a City field to NotteProxy, prefixed SessionResponseBrowserType constants, and new SecretMetadata/SecretListResponse/SecretStoreRequest models. No logic is hand-written; changes are consistent with the existing generated code pattern.

Fix All in Codex

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
internal/api/client.gen.go:1910-1945
**Missing tests for new endpoints**

This PR introduces two significant new API surface areas — profile cookies (`ProfileCookiesGet`/`ProfileCookiesSet`) and secrets management (`ListSecrets`, `StoreSecret`, `GetSecret`, `DeleteSecret`) — but no corresponding CLI command files or tests accompany them. Existing analogous features like profiles have tests in `internal/cmd/profiles_test.go`. Per the project's test guidelines, at least one integration test should cover new major features.
- Add a comment if the PR does n... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))

Reviews (2): Last reviewed commit: "Update generated client from staging Ope..." | Re-trigger Greptile

@leo-notte leo-notte merged commit 3bf5dac into main Jun 3, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant