Update generated CLI client from staging OpenAPI#45
Merged
Conversation
339b654 to
be9a79b
Compare
|
| Filename | Overview |
|---|---|
| internal/api/client.gen.go | Regenerated OpenAPI client adding profile cookies (GET/SET) and secrets management (List/Get/Store/Delete) endpoints, a City field to NotteProxy, prefixed SessionResponseBrowserType constants, and new SecretMetadata/SecretListResponse/SecretStoreRequest models. No logic is hand-written; changes are consistent with the existing generated code pattern. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
internal/api/client.gen.go:1910-1945
**Missing tests for new endpoints**
This PR introduces two significant new API surface areas — profile cookies (`ProfileCookiesGet`/`ProfileCookiesSet`) and secrets management (`ListSecrets`, `StoreSecret`, `GetSecret`, `DeleteSecret`) — but no corresponding CLI command files or tests accompany them. Existing analogous features like profiles have tests in `internal/cmd/profiles_test.go`. Per the project's test guidelines, at least one integration test should cover new major features.
- Add a comment if the PR does n... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))
Reviews (2): Last reviewed commit: "Update generated client from staging Ope..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification