text: avoid spurious font atlas growth - #1063
Merged
Merged
Conversation
Owner
|
Thanks for PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Atlas::cache_spriteplaces a sprite atcursor_x + GAP, but its row-fit check did not reserve that margin. A sprite that crossed the right edge by one pixel was therefore placed out of bounds and grew the atlas instead of starting a new row.This checks the placement bound in
u32, keeps exact right-edge placement valid, and repacks cached sprites in a deterministic order when the atlas grows.Fixes #1054
Verification
cargo test --libcargo build --all-targetscargo check --lib --target wasm32-unknown-unknown