Forge 26.1/26.2 build support#1
Closed
not-coded wants to merge 2 commits into
Closed
Conversation
Working-tree state of the Stonecutter 0.9.6 rework adding 26.x targets: per-loader buildscripts, TOML version properties, loom-no-remap for unobfuscated 26.x, reusable CI workflows.
- drop corrupted IDE auto-imports and Entities.EscapeMode reference that broke buildscript compilation for every forge target - guard mappings/remapJar behind obfuscated flag; 26.x uses loom-no-remap where remap tasks do not exist (matches fabric script) - shedaniel ships no Forge cloth-config past 17.0.144 (MC 1.21.3); 26.x pulls the community port maven.modrinth:cloth-config-forge (same cloth_config modid) via Modrinth maven - add missing [forge."26.2"] properties (Forge 65.0.5, cloth 26.2.155) - ModList.get() removed in Forge 62+; API is static, add >=26.1 guard
Owner
Author
|
Superseded — changes applied directly to main checkout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Forge 26.1 and 26.2 Stonecutter targets build. Includes a snapshot commit of the in-progress 26.x migration from the working tree, plus the actual fixes in the second commit.
Fixes (second commit)
build.forge.gradle.ktsscript compilation — removed corrupted IDE auto-imports (com.sun.imageio…JPEG.vendor,jdk.jfr.internal.JVM.exclude, jsoupEntities) and restoredbase.archivesName; these broke every forge target.mappings()/remapJar/remapSourcesJarnow guarded behind anobfuscatedflag (same pattern as the fabric script); 26.x uses loom-no-remap where remap tasks don't exist, sojar/sourcesJarare used for buildAndCollect and publishMods.maven.modrinth:cloth-config-forge, verified samecloth_configmodid) via Modrinth maven with exclusiveContent filtering. 1.x targets keep shedaniel's maven.[forge."26.2"]properties — added: Forge loader 65.0.5 (latest for MC 26.2), cloth 26.2.155.ModList.get()removed in Forge 62+ — the API is now fully static; added a>=26.1stonecutter guard usingModList.isLoaded(modId).Verification
:26.1-forge:buildand:26.2-forge:buildpass; jars contain expandedmods.tomlwith correct version ranges.chiseledBuildacross all 27 targets passes (what CI runs) — no regressions; forge jars collected for 1.16.x through 26.2.Note: runtime dependency for players on Forge 26.x is the community cloth-config port, not shedaniel's — worth a mention in the Modrinth/CurseForge description.