fix: relay negentropy sync panic on wasm - #1405
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
yukibtc
approved these changes
Jul 30, 2026
…ync API This fixes panic on WASM environment. Pull-Request: nostrdevkit#1405 Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
Member
|
Why the tests did not cover this panic? |
Member
Tests aren't executed for WASM. Cargo test doesn't work for WASM, but we need to figure out a solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the negentropy sync is using
Instantfromstd::timewhich will cause panic on wasm enviroment. Solution: migrate touniversal_timeNotes to the reviewers
Checklist