Skip to content

Make Send bounds explicit per API - #1400

Merged
yukibtc merged 1 commit into
masterfrom
send-bound
Jul 27, 2026
Merged

Make Send bounds explicit per API#1400
yukibtc merged 1 commit into
masterfrom
send-bound

Conversation

@yukibtc

@yukibtc yukibtc commented Jul 26, 2026

Copy link
Copy Markdown
Member

Follow-up of ae1f2fc

Fixes #1399

@yukibtc yukibtc changed the title Make stream Send bounds explicit per API Make Send bounds explicit per API Jul 26, 2026
@reyakov

reyakov commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

it's fully work now. but the nostr-connect isn't fully migrate yet.

@yukibtc

yukibtc commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

it's fully work now. but the nostr-connect isn't fully migrate yet.

What error do you get?

@reyakov

reyakov commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

it's fully work now. but the nostr-connect isn't fully migrate yet.

What error do you get?

I got this error:

rror: future cannot be sent between threads safely
   --> /Users/reya/.cargo/git/checkouts/nostr-619b808bb247a9ed/edf9ab4/signer/nostr-connect/src/client.rs:541:9
    |
541 |         Box::pin(async move { self._nip44_decrypt(*public_key, payload.to_string()).await })
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ future created by async block is not `Send`
    |
    = help: the trait `std::marker::Send` is not implemented for `dyn Future<Output = Result<Output<SubscriptionId>, Error>>`
note: future is not `Send` as this value is used across an await

@yukibtc

yukibtc commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

@reyakov, it should be fixed now

Follow-up of ae1f2fc

Fixes #1399

Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@reyakov

reyakov commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@reyakov, it should be fixed now

it's work fine now.

@yukibtc
yukibtc merged commit d331bed into master Jul 27, 2026
44 of 45 checks passed
@yukibtc
yukibtc deleted the send-bound branch July 27, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Send issues on WASM

2 participants