nwc: support nip44_v2 - #1393
Merged
Merged
Conversation
TheAwiteb
force-pushed
the
nwc-nip44v2
branch
2 times, most recently
from
July 16, 2026 09:34
7b33a07 to
3446dc1
Compare
TheAwiteb
marked this pull request as ready for review
July 16, 2026 09:43
Member
Author
|
Hello @yukibtc and @MegalithicBTC, I don't have a wallet service to test this code with, but I believe it's correct. Could you please review it? |
TheAwiteb
marked this pull request as draft
July 18, 2026 14:32
Member
Author
|
I'll add the tests soon |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
TheAwiteb
force-pushed
the
nwc-nip44v2
branch
2 times, most recently
from
July 20, 2026 11:55
118324b to
5016486
Compare
TheAwiteb
marked this pull request as ready for review
July 20, 2026 11:56
yukibtc
requested changes
Jul 21, 2026
Signed-off-by: Awiteb <a@4rs.nl>
Signed-off-by: Awiteb <a@4rs.nl>
Signed-off-by: Awiteb <a@4rs.nl>
Signed-off-by: Awiteb <a@4rs.nl>
``` test nips::nip47::tests::test_encryption_tag_parsing ... ok test nips::nip47::tests::test_encryption_tag_display ... ok test nips::nip47::tests::test_request_encryption ... ok test nips::nip47::tests::test_response_decryption ... ok test nips::nip47::tests::test_notification_decryption ... ok ``` Signed-off-by: Awiteb <a@4rs.nl>
``` test tests::test_send_request_no_cipher ... ok test tests::test_send_request_nip04_cipher_no_info ... ok test tests::test_send_request_nip04_cipher_with_info ... ok test tests::test_send_request_nip44_cipher_no_info ... ok test tests::test_send_request_no_cipher_but_info_single_old_cipher ... ok test tests::test_send_request_no_cipher_but_info_latest_cipher ... ok test tests::test_send_request_no_cipher_but_info_single_cipher ... ok ``` Signed-off-by: Awiteb <a@4rs.nl>
Signed-off-by: Awiteb <a@4rs.nl>
yukibtc
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #1392
Description
Support NIP44 in nwc, the user should fetch the wallet service info event and enable
nip44_v2if it supports it.Checklist