Skip to content

feat(sdd-validate): gate PR validation to suite branches#168

Merged
norrietaylor merged 2 commits into
mainfrom
feat/sdd-validate-branch-gate
May 29, 2026
Merged

feat(sdd-validate): gate PR validation to suite branches#168
norrietaylor merged 2 commits into
mainfrom
feat/sdd-validate-branch-gate

Conversation

@norrietaylor
Copy link
Copy Markdown
Owner

Problem

sdd-validate triggers on pull_request: [opened, synchronize] with no provenance filter, so it posts a findings comment on every PR — dependabot bumps, external contributions, unrelated human PRs. Non-suite PRs resolve to the implementation boundary and get commented on (and can draw needs-human on a protected-path or credential hit).

Fix

Gate the pull_request path to suite branches by head-ref prefix (spec/, arch/, sdd/):

  • Job-level if: so non-suite PRs spawn no runner.
  • Re-checked in the route script as defense in depth (mirrors the existing parent-issue check on the issues path).

Suite PRs carry no distinguishing label (the lifecycle label lives on the tracking issue), so the head ref is the signal — matching CLAUDE.md branch conventions and the head-ref routing in sdd-execute/sdd-dispatch.

The issues path is already gated to labeled sdd:ready on a parentless tracking issue; not a noise source, unchanged.

Verification

  • YAML parses; embedded github-script passes node --check
  • startsWith(github.event.pull_request.head.ref, …) matches the expression form already used in sdd-dispatch.yml/sdd-execute-*.yml

🤖 Generated with Claude Code

Only validate pull requests whose head ref is a suite branch (spec/, arch/,
sdd/). Without the gate, sdd-validate commented on every opened/synchronized
PR — dependabot bumps, external contributions, unrelated human PRs. Suite PRs
carry no distinguishing label, so the head ref is the signal, matching
CLAUDE.md branch conventions and the sdd-execute/sdd-dispatch wrappers. The
issues path is already gated to sdd:ready on a parentless tracking issue and
is unchanged.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@norrietaylor, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 51 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6a58c1a9-f8a0-410d-bef0-4423800a0a17

📥 Commits

Reviewing files that changed from the base of the PR and between cf15161 and f13280d.

📒 Files selected for processing (1)
  • wrappers/sdd-validate.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/sdd-validate-branch-gate

Comment @coderabbitai help to get the list of available commands and usage tips.

@norrietaylor norrietaylor merged commit 9acebda into main May 29, 2026
9 checks passed
@norrietaylor norrietaylor deleted the feat/sdd-validate-branch-gate branch May 29, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant