feat(sdd-validate): gate PR validation to suite branches#168
Conversation
Only validate pull requests whose head ref is a suite branch (spec/, arch/, sdd/). Without the gate, sdd-validate commented on every opened/synchronized PR — dependabot bumps, external contributions, unrelated human PRs. Suite PRs carry no distinguishing label, so the head ref is the signal, matching CLAUDE.md branch conventions and the sdd-execute/sdd-dispatch wrappers. The issues path is already gated to sdd:ready on a parentless tracking issue and is unchanged.
|
Warning Review limit reached
More reviews will be available in 19 minutes and 51 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Problem
sdd-validatetriggers onpull_request: [opened, synchronize]with no provenance filter, so it posts a findings comment on every PR — dependabot bumps, external contributions, unrelated human PRs. Non-suite PRs resolve to the implementation boundary and get commented on (and can drawneeds-humanon a protected-path or credential hit).Fix
Gate the
pull_requestpath to suite branches by head-ref prefix (spec/,arch/,sdd/):if:so non-suite PRs spawn no runner.Suite PRs carry no distinguishing label (the lifecycle label lives on the tracking issue), so the head ref is the signal — matching CLAUDE.md branch conventions and the head-ref routing in
sdd-execute/sdd-dispatch.The
issuespath is already gated tolabeledsdd:readyon a parentless tracking issue; not a noise source, unchanged.Verification
github-scriptpassesnode --checkstartsWith(github.event.pull_request.head.ref, …)matches the expression form already used insdd-dispatch.yml/sdd-execute-*.yml🤖 Generated with Claude Code