Skip to content

chore(eip): add live endpoint test controls#77

Open
benliepert wants to merge 4 commits into
mainfrom
benliepert/CON-1818-eip-live-endpoint-public
Open

chore(eip): add live endpoint test controls#77
benliepert wants to merge 4 commits into
mainfrom
benliepert/CON-1818-eip-live-endpoint-public

Conversation

@benliepert

Copy link
Copy Markdown
Contributor

Summary

  • move https://github.com/nominal-io/instrumentation/pull/245 onto the public nominal-io/instro repo
  • add env-driven EtherNet/IP integration target selection for simulator vs live PLC endpoint
  • add route-path slot, unsigned-type exclusion, and L32E target preset controls
  • add eip-live-test plus a DNM local proxy recipe/script for current local NECP/network policy issues

Conflict resolution

  • resolved public-repo package/name conflicts by keeping the instro-* package names and adding only the PR's new cpppo dev dependency
  • kept public pytest handling in the existing test dependency group

DNM note

This branch currently includes tests/dnm_eip_live_proxy.py and just dnm-eip-live-test as a temporary workaround. Local direct TCP from Rust/Python dev binaries to 10.123.1.199:44818 is blocked by macOS NECP / endpoint security policy, while Apple platform binaries can connect. The proxy exists only so the live PLC tests can be confirmed until that local networking issue is resolved.

Verification

  • uv lock --check
  • cargo test -p instro-ethernetip-rs --test explicit_session_integration
  • uv run --no-cache --reinstall-package instro-ethernetip-python --with-editable . pytest tests/test_ethernetip_bindings.py -q
  • just check
  • just test

Comment thread uv.lock
{ url = "https://files.pythonhosted.org/packages/16/8d/0a993fbf40ec406d0162034876ae9b926972f844653ab3e77cbef29bba3d/pyaardvark-0.8.1-py3-none-any.whl", hash = "sha256:a96176124444d6b860486561afd2aaceeb5b7ad201bf05626729edee00e6c73f", size = 263312, upload-time = "2024-04-16T15:44:33.576Z" },
]

[[package]]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legal Risk

pycryptodome 3.23.0 was released under the non-standard license, a license that
is currently prohibited by your organization. Merging is blocked until this is resolved.

Recommendation

Reach out to your security team or Semgrep admin to address this issue. In special cases, exceptions may be made for dependencies with violating licenses, however, the general recommendation is to avoid using a dependency under such a license.

@benliepert benliepert marked this pull request as ready for review June 10, 2026 17:14
NthTensor
NthTensor previously approved these changes Jun 11, 2026

@NthTensor NthTensor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passing locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants