chore(ethernetip): add cpppo integration tests#69
Open
benliepert wants to merge 4 commits into
Open
Conversation
(cherry picked from commit c86babbc9b681aaf3cabaac26dd5a3f15cd7bb34)
(cherry picked from commit 2e98fa1ad0233ef5b2d8f08b50b85efd2fae2d8e)
![semgrep-code-nominal-io[bot]](https://avatars.githubusercontent.com/u/116665555?s=60&v=4){kind=small}
| { url = "https://files.pythonhosted.org/packages/16/8d/0a993fbf40ec406d0162034876ae9b926972f844653ab3e77cbef29bba3d/pyaardvark-0.8.1-py3-none-any.whl", hash = "sha256:a96176124444d6b860486561afd2aaceeb5b7ad201bf05626729edee00e6c73f", size = 263312, upload-time = "2024-04-16T15:44:33.576Z" }, | ||
| ] | ||
|
|
||
| [[package]] |
There was a problem hiding this comment.
Legal Risk
pycryptodome 3.23.0 was released under the non-standard license, a license that
is currently prohibited by your organization. Merging is blocked until this is resolved.
Recommendation
Reach out to your security team or Semgrep admin to address this issue. In special cases, exceptions may be made for dependencies with violating licenses, however, the general recommendation is to avoid using a dependency under such a license.
benliepert
requested review from
NthTensor and
cartercanedy
and removed request for
cartercanedy
NthTensor
approved these changes
Jun 11, 2026
NthTensor
left a comment
NthTensor
left a comment
There was a problem hiding this comment.
Tests pass. Approved conditional on the legal stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from nominal-io/instrumentation#228.