stream: validate fromWritable() options before cache#63278
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Validate options before returning a cached fromWritable() adapter so invalid later options still throw. Cache adapters by backpressure policy as well as Writable instance, since the policy changes write behavior. Fixes: nodejs#63277 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
2785bd3 to
eb326fb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63278 +/- ##
==========================================
- Coverage 90.04% 90.03% -0.02%
==========================================
Files 713 714 +1
Lines 225003 225250 +247
Branches 42536 42576 +40
==========================================
+ Hits 202606 202805 +199
- Misses 14177 14218 +41
- Partials 8220 8227 +7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
stream/iterfromWritable()cache handling so later options arevalidated and applied correctly.
Previously,
fromWritable(writable)cached a strict writer, and later callssuch as
fromWritable(writable, { backpressure: 'drop-newest' })returned thatcached strict writer before validating or applying the new options. This also
meant invalid later options did not throw.
This updates
fromWritable()to validate options before cache lookup and cachewriters by both
Writableinstance and backpressure policy.Fixes: #63277
Assisted-by: openai:gpt-5.5