node-api: support SharedArrayBuffer in napi_create_typedarray#62710
Merged
nodejs-github-bot merged 4 commits intoMay 13, 2026
Merged
Conversation
Signed-off-by: umuoy1 <burningdian@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Signed-off-by: umuoy1 <burningdian@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62710 +/- ##
==========================================
- Coverage 89.81% 89.64% -0.17%
==========================================
Files 699 708 +9
Lines 216379 220381 +4002
Branches 41366 42270 +904
==========================================
+ Hits 194340 197569 +3229
- Misses 14139 14676 +537
- Partials 7900 8136 +236
🚀 New features to boost your workflow:
|
Signed-off-by: umuoy1 <burningdian@gmail.com>
umuoy1
changed the title
legendecas
reviewed
Apr 27, 2026
legendecas
reviewed
Apr 27, 2026
Member
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
Generally LGTM. Thanks for the PR!
Contributor
Author
|
Thanks! I have addressed the suggestion. |
legendecas
approved these changes
Apr 28, 2026
legendecas
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
vmoroz
approved these changes
Apr 28, 2026
Collaborator
Contributor
Author
|
Hi @legendecas @vmoroz , just checking in on this PR. It has two approvals now, and CI has run after the latest commit. Is there anything else I should do, or could it be added to the commit queue if everything looks good? Thanks! |
legendecas
added
the
author ready
Collaborator
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c24e552 |
github-project-automation
Bot
moved this from In Progress
to Done
in Node-API Team Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
napi_create_typedarray()to acceptSharedArrayBufferin addition toArrayBuffer.Today,
napi_create_dataview()already accepts bothArrayBufferandSharedArrayBuffer, butnapi_create_typedarray()still only acceptsArrayBuffer. This creates an inconsistency in Node-API behavior and does not align with JavaScript semantics, where TypedArrays can be backed bySharedArrayBuffer.