Skip to content

chore: replace var with let/const in isRealPathSafe#135

Merged
fengmk2 merged 1 commit into1.xfrom
fix/lint-var-to-const-1.x
Apr 13, 2026
Merged

chore: replace var with let/const in isRealPathSafe#135
fengmk2 merged 1 commit into1.xfrom
fix/lint-var-to-const-1.x

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Apr 13, 2026

Summary

  • Replace var with let/const in isRealPathSafe() in lib/utils.js to fix 6 eslint no-var errors introduced by the GHSA-4c3q-x735-j3r5 fix.

Test plan

  • npm run lint passes with 0 errors

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: adc8ec1f-d352-4077-829b-73a4f068dfd1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lint-var-to-const-1.x

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fengmk2 fengmk2 changed the title fix: replace var with let/const in isRealPathSafe chore: replace var with let/const in isRealPathSafe Apr 13, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates lib/utils.js by replacing var declarations with const and let to align with modern JavaScript standards. I have no feedback to provide as there were no review comments and the changes are appropriate.

@fengmk2 fengmk2 merged commit 60fa3af into 1.x Apr 13, 2026
21 of 22 checks passed
@fengmk2 fengmk2 deleted the fix/lint-var-to-const-1.x branch April 13, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant