Move cab OBS source URLs to the stream dashboard - #635
Open
noahm wants to merge 3 commits into
Open
Conversation
Grabbing several source URLs in a row meant re-opening the same three levels of submenu for each one. The cab menu now just links over to the stream dashboard, which grew a collapsible "Cab OBS Sources" section listing every source for a chosen cab with its URL and a copy button. The player rows are driven by a count input rather than hardcoded to player 1, so the old "(edit URL for players beyond 1)" hint is gone. Cab source paths are now written relative to the event route, matching the global label paths, since the dashboard sits one level deeper than the cab sidebar did. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HR7hcxtbUhcbeThy9JyVCL
Below ~900px the url gets cut off before the part that distinguishes one source from the next, so every row reads the same. Drop it there and let the label take the width; the copy button is unaffected.
The dashboard's cab source section now keeps its whole state in the url: `?cab=<id>` both expands the section and picks the cab it's showing, so a particular cab's sources can be linked to or bookmarked directly. Each cab's menu links straight at its own id. Switching cabs and collapsing replace the current entry rather than push, so the back button leaves for the main view instead of walking back through the churn. An unknown id (a cab removed since the link was made) still opens the section, on the first cab. Arriving with the section open scrolls it into view, since any number of text sources can be listed above it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grabbing several OBS source URLs in a row meant re-opening the same three levels of submenu for every one of them. This moves them all onto the stream dashboard, where they can be scanned and copied from a list.
Cab sidebar
The
…menu on each cab is now two items: OBS Sources › dashboard and Remove Cab. The submenu tree is gone; the link goes straight to that cab's sources.Dashboard
A collapsible Cab OBS Sources section, closed by default, between the text sources and the CSS editor:
(edit URL for players beyond 1)hintLinkable selections
The section keeps its whole state in the url —
?cab=<id>both expands it and names the cab — so a particular cab's sources can be bookmarked or shared, and each cab's menu links at its own id. Switching cabs and collapsing usereplacerather than push, so the back button leaves for the main view instead of walking back through the churn. A link to a cab removed since still opens the section, on the first cab. Arriving with the section open scrolls it into view, since any number of text sources can sit above it.Notes
../cab/…), matching the global label paths, since the dashboard sits one level deeper than the sidebar did.…/cab/default/sourc…, cut off right before the part that tells sources apart. This page is often docked narrow inside OBS.docs/obs.mdwalked through the removed menu, so that passage is rewritten and both screenshots refreshed.Testing
yarn validateis clean. Driven against a local dev server + partykit backend with Playwright:/e/<room>/dash?cab=<id>with the section expanded on that cab, and its source URLs point at that cab?cab=scrolls it fully into view; arriving without the param leaves the page at the topOne thing I left alone: the cab
<select>clips descenders slightly. That's a pre-existing globalselect { font-size: 16px !important }inapp.css(an iOS auto-zoom guard) affecting everyHTMLSelectin the app, so fixing it belongs in its own change.🤖 Generated with Claude Code
https://claude.ai/code/session_01HR7hcxtbUhcbeThy9JyVCL
Generated by Claude Code