fix(ui): use muted_text for empty font/modifier picker states - #81
Open
VedantMadane wants to merge 1 commit into
Open
fix(ui): use muted_text for empty font/modifier picker states#81VedantMadane wants to merge 1 commit into
VedantMadane wants to merge 1 commit into
Conversation
Empty-state labels in font_picker and modifier_picker used a hardcoded mid-grey that ignores the active theme. Route them through styles::muted_text so light themes get the same muted secondary colour as info_panel and preferences. Fixes nnmarcoo#69 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Empty-state labels in the font and modifier pickers used a hardcoded mid-grey (Color::from_rgba(0.6, 0.6, 0.6, 1.0)), which ignores the active theme. On light themes that grey is hard to read and inconsistent with other secondary labels.
This routes both empty states through styles::muted_text(theme), matching info_panel and preferences.
Changes
Test plan
Fixes #69