Resolve downloads from the release list when latest 404s - #80
Closed
nnmarcoo wants to merge 1 commit into
Closed
Conversation
/releases/latest skips prereleases and returns 404 while every tag is a pre-alpha, so the per-platform download menu has never rendered. Falling back to the release list alone is not enough. That list reaches the archival pre-alpha releases, whose assets belong to the old app and are named img_*, so the menu would have offered a February build of a different program. Only bloom-* assets count now, and a release carrying none of them is skipped.
Owner
Author
|
Closing unmerged. The fallback solves a problem that goes away on its own. /releases/latest only 404s because every tag so far is a prerelease. Cutting a public release fixes it, and the existing resolver already picks the right asset per platform from a real release payload, full variant, ignoring a checksums file. It is also mildly counterproductive. A rate-limited 403 lands in the .catch, so the fallback fires a second request that is also rate limited and also fails. Two failed requests instead of one, plus a hard dependency on the bloom-* artifact prefix in release.yml. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55.
/releases/latestskips prereleases. Every tag is a-pre-alpha, so it 404s and the per-platform download menu has never rendered on bloomview.rs. Confirmed live:Nothing looked broken because
.catch(() => {})leaves the plain Download button pointing at/releases, which is why this sat unnoticed.Falling back to the release list turned out to be the wrong fix on its own. I ran the patched resolver against the live API and it cheerfully resolved this:
Those are the archival releases from the old app. A visitor would have been handed a February build of a different program under a Download button. That is worse than the button doing nothing.
So the fallback also requires assets named
bloom-*, which every artifactrelease.ymlproduces already is, and skips any release carrying none. Behaviour I verified:/releases/releases/latesthits, fallback never runsThe
bloom-prefix is the load-bearing part. If artifact naming ever changes inrelease.yml, this needs to change with it, and the comment in the file says so.Touches
docs/index.htmlalongside the #62 PR, but different hunks.