Say which platforms and architectures ship - #79
Merged
Conversation
The README implied macOS generally while release.yml builds only on macos-14, which is arm64. Intel Macs have no download. MACOSX_DEPLOYMENT_TARGET was set to 10.15 on that arm64-only build, where the floor is 11.0, so the value did nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62.
Two related things, both about the macOS claim being wider than the builds.
The README listed Windows, macOS and Linux with no mention of architecture. release.yml builds macOS on
macos-14, which is arm64 only, so Intel Macs have never had a download. The README now names the three targets that actually ship and says Intel needs a source build. The download button on the site says "macOS (Apple Silicon)" rather than "macOS".MACOSX_DEPLOYMENT_TARGETwas pinned to 10.15 on that arm64-only build. arm64 macOS starts at 11.0, so the setting did nothing at all. It is 11.0 now, which is the real floor and leaves a correct value to widen if an Intel job shows up.I deliberately did not add the Intel build here, though it is the better fix for Intel users. release.yml only runs on tags, so a new matrix entry gets zero validation in this PR and would first execute during your actual release. That is the exact failure mode #55 is about, and I would rather not introduce a second one while fixing the first. Adding
macos-13is maybe fifteen lines and I am happy to do it as its own PR, ideally triggered once manually through workflow_dispatch before a real tag depends on it.One heads-up: this touches
docs/index.htmlline 116, and the #55 PR touches the fetch logic further down the same file. Different hunks, so they should merge cleanly in either order.