Describe the artifacts the release actually builds - #78
Merged
Conversation
install.html told Linux users to run an AppImage or install a .deb, and mentioned a Windows .exe installer. The release workflow publishes only tar.gz, dmg, zip and msi, so none of those files have ever existed. Also documents that the Linux full build needs lib/ kept beside the binary, since it links FFmpeg through an $ORIGIN/lib rpath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50.
The install page told Linux users to
chmod +x bloom-*.AppImageorsudo dpkg -i bloom_*.deb, and pointed Windows users at a.exeinstaller. The release workflow uploadsbloom-*.tar.gz,bloom-*.dmg,bloom-*.zipandbloom-*.msi. No AppImage, no .deb, no .exe, so anyone on Linux following the page had nothing to download.Now it describes the tarball. It also documents something that was not written down anywhere: the Linux full build links FFmpeg through an
$ORIGIN/librpath, solib/has to stay next to the binary. Extract the tarball and movebloomsomewhere on its own and video silently stops working.The macOS text was already correct and I left it alone.
This makes the docs true today. Shipping an AppImage and a .deb is still the better answer for Linux, and I would rather do that as its own PR than bolt packaging onto a docs fix. Happy to pick it up next if you want it.
Also updated the search index entry, which indexed appimage, dpkg and deb as keywords.