Skip to content

Revise tsconfig.json#63

Open
graphemecluster wants to merge 6 commits into
dev-0.16from
tsconfig
Open

Revise tsconfig.json#63
graphemecluster wants to merge 6 commits into
dev-0.16from
tsconfig

Conversation

@graphemecluster

@graphemecluster graphemecluster commented Nov 24, 2025

Copy link
Copy Markdown
Member

There are quite some redundant options that make the file hard to read, so I replaced it with the new official template with some additions.

Partially depends on #62. Do not merge this before merging #62.

Comment thread tsconfig.json
"typeRoots": ["node_modules/@types", "src/types"]
// Additional Options Added
// "isolatedDeclarations": true,
"moduleResolution": "Bundler",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moduleResolution should have been Bundler since the migration to Bun.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should have been so all the way back when "moduleResolution": "Bundler" was a thing (that's Typescript 5.0 btw), as we've been using a bundler all the time 😂

Comment thread tsconfig.json

"lib": ["es2023"],
"types": [],
"typeRoots": ["node_modules/@types", "src/types"]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is src/types for? Is it legacy?

@graphemecluster

Copy link
Copy Markdown
Member Author

39b33e0 is an alternative solution to fc60589 and it entirely skips visible TypeScript transpilation of test files. Without the commit, the project doesn't build correctly, so it was included as part of the PR.
Again, although Bun supports TypeScript out of the box, unfortunately, we can't use bunx --bun nyc ... due to an unimplemented API in Bun, so we will have to strip types using the Node flag.

@graphemecluster
graphemecluster force-pushed the tsconfig branch 2 times, most recently from 8568f78 to 23def62 Compare November 24, 2025 13:40
Suppress output if there are type errors since the type checking and emitting process for the test files is abolished
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants