fix(build): raise minimum cfg_aliases to 0.2.2 - #2811
Closed
jzuber4 wants to merge 1 commit into
Closed
Conversation
nix's build script invokes the `cfg_aliases!` macro. Under `cargo -Zdirect-minimal-versions`, cargo pins the declared floor (0.2.1), whose macro expansion ends in a trailing semicolon in expression position. Current Rust treats that as a hard error, so the build script fails to compile and the `minver` CI job breaks. cfg_aliases 0.2.2 restructured the macro to drop the trailing semicolon. Raising the floor to 0.2.2 makes the minimum-versions build compile. cfg_aliases is a build-dependency only (not part of nix's public API), edition 2018, with no dependencies and no MSRV bump, so nix's consumers and MSRV are unaffected.
jzuber4
force-pushed
the
fix-minver-cfg-aliases
branch
from
August 13, 2026 12:35
0301111 to
105094b
Compare
3 tasks
Author
|
Superseded by #2812, which keeps this |
Contributor
|
Duplicate of #2808 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Raises the minimum
cfg_aliasesbuild-dependency from 0.2.1 to 0.2.2.nix's
build.rsinvokes thecfg_aliases!macro. Undercargo -Zdirect-minimal-versions, cargo pins the declared floor (0.2.1),whose macro expansion contains a trailing semicolon in expression position.
Current Rust promotes that from a warning to a hard error, so the build script
fails to compile and the
minverCI job is red. (This is currently failing onmaster, independent of any individual PR.)cfg_aliases0.2.2 restructured the macro to remove the trailing semicolon, soraising the floor makes the minimum-versions build compile again.
cfg_aliasesis a build-dependency only — it is not part of nix's public API — is edition
2018 with no dependencies and no declared MSRV, so this has no effect on nix's
consumers or on nix's MSRV.
Checklist:
CONTRIBUTING.md