Fix timing-sensitive broker test flakes - #218
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the timing-sensitive broker test flakes tracked under #215.
RabbitMQ publisher confirms
The old test configured sync publisher confirms with
:timeout-ms 1and expected RabbitMQ to be slow enough to throwTimeoutException. RabbitMQ can legitimately confirm within 1ms, which made the test fail intermittently withactual: nil.This replaces the wall-clock race with a deterministic timeout path by redefining
langohr.confirm/wait-for-confirmsto throwTimeoutExceptionfor this assertion.Redis scheduled jobs range ordering
The old
scheduled-jobs-get-by-rangetest created one job at(u/epoch-time-ms).scheduler/run-atcompares that value against a fresh current time and moves past jobs directly to the ready queue, so the job could disappear from the scheduled sorted set if the clock advanced by 1ms.This now uses two future timestamps for the ordering assertion, keeping both jobs in the scheduled sorted set deterministically.
Validation
clj-kondo --lint test/goose/brokers/redis/api_test.clj test/goose/brokers/rmq/integration_test.clj --fail-level errorclj -X:test :nses '[goose.brokers.redis.api-test goose.brokers.rmq.integration-test]'