Migrate common broker integration tests to DSL - #217
Merged
Conversation
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the common Redis/RabbitMQ broker integration scenarios into the new integration test DSL introduced in #214.
Common scenarios now covered through
goose.integration.goose-test:The older broker-specific integration namespaces have been pruned to retain only broker-specific coverage:
This continues the migration tracked in #216 and follows the common abstraction direction discussed in #202. It also leans further into the execution promise/delivery semantics from #214 for middleware/retry/death assertions.
Validation
clj-kondo --lint bb.edn deps.edn src test --fail-level errorclj -X:test :nses '[goose.integration.goose-test goose.brokers.redis.integration-test goose.brokers.rmq.integration-test]'Ran 14 tests containing 75 assertions. 0 failures, 0 errors.