chore(renovate): group go toolchain bumps across managers into one PR#288
Merged
Charles Chiu (charliie-dev) merged 2 commits intoJul 16, 2026
Merged
Conversation
Go's version lives in three managers — go.mod (gomod), dhi.io/golang (dockerfile), and mise.toml (mise) — each in its own per-manager group, so their bumps opened as separate PRs that merged out of step (mise's went in while go.mod and the base image lagged). Add a packageRule grouping depName `go` and `dhi.io/golang` into one `go toolchain` group with dashboard approval off, so the combined bump opens as a single reviewable PR. Surfaced by nics-dp/otel-bundle#125.
Contributor
There was a problem hiding this comment.
Pull request overview
此 PR 將跨 Renovate managers 的 Go 更新集中至同一群組,以降低版本漂移。
Changes:
- 新增
go toolchainRenovate 群組。 - 停用 dashboard approval 與 automerge。
- 發現 manager 範圍過廣,且群組無法保證版本同步。
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… claim Copilot review on #288 flagged two real issues: - matchDepNames alone matched `go` across every ecosystem (e.g. an npm package named `go`) and would have overridden its dashboard-approval policy. Add matchManagers [gomod, mise, dockerfile, custom.regex] so the rule only touches the intended Go toolchain deps. - groupName batches whatever updates are available in a run; it does not wait for all members or force identical versions. Reword the description to claim a narrowed drift window rather than lockstep.
Charles Chiu (charliie-dev)
deleted the
feature/renovate-group-go-toolchain
branch
July 16, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #289
Why
Go's version is tracked by three Renovate managers, each in its own
per-manager group in this preset (gomod →
go dependenciesdashboard-only,dockerfile →
docker dependencies, mise →mise dev tools). So a Go bumpopens as three separate PRs on different schedules that merge out of step —
nics-dp/otel-bundle#123merged the mise bump to 1.26.5 whilego.modand thedhi.io/golangdigest lagged. That's what surfaced this.What
Add a
packageRule(placed last, overriding the per-manager groups) groupingthe Go toolchain into one
go toolchainPR:matchManagers: [gomod, mise, dockerfile, custom.regex]+matchDepNames: [go, dhi.io/golang]— scoped so an unrelatedgodep in another ecosystem(e.g. an npm package) is not swept in, and its update policy stays untouched.
go(otel-bundle adds one) joinautomatically.
dependencyDashboardApproval: falseso the combined bump opens directly;automerge: falseso a human reviews the single PR.Scope of the guarantee
groupNamebatches whatever updates are available in a given run — it doesnot wait for every member or force identical versions across datasources.
This narrows the drift window (no more one-manager-merges-alone, i.e. #123's
failure mode) rather than guaranteeing lockstep.
Affects every downstream repo consuming this preset. Validated with
renovate-config-validator(renovate 43.x). Surfaced by nics-dp/otel-bundle#125.