Add MKV (Matroska/WebM) steganography engine#22
Open
niclashedam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fourth engine,
MkvEngine, giving Lupin Matroska (.mkv) and WebM support, detected via the EBML header magic. It hides the payload behind aLupin\0signature in an EBMLVoidelement appended as the last child inside the Segment.Voidis the spec's reserved/padding primitive that every conformant reader skips, so the media streams and playback are untouched.The approach is safe on real files because Matroska seek indexes (
SeekHead/Cues) are Segment-relative: appending after all existing children preserves every offset, so no re-indexing is needed. The Segment size field is rewritten for known-size Segments and left alone for unknown-size ones. Verified against a real ffmpeg-produced.mkv— embed/extract round-trips, the decoded video is bit-identical (same MD5), and full-frame decode reports no errors.Registered in
EngineRouterso the CLI and API pick it up automatically. AddsLupinError::MkvInvalidFormat/MkvNoHiddenData, 15 engine tests,examples/cat.mkv+examples/out.mkvsamples, and docs. Capacity-only, consistent with the other engines;EmbedMode::StealthreturnsStealthNotSupported.