ci: deploy Firestore rules and indexes alongside functions - #69
Merged
Conversation
The deploy workflow only shipped hosting and functions, so rules changes (like the OAuth 2.1 lockdown in #68) never reached prod. firebase deploy --only firestore covers rules + indexes per firebase.json. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Deploy to Firebase Hostingworkflow deployed hosting + functions but never Firestore rules, so the OAuth 2.1 rules lockdown from #68 (client-write ban onoauthClients,oauthGrantsread access for the Connected Apps screen) is not yet live. This extends the deploy step to--only functions,firestore, which covers rules and indexes as configured in firebase.json.Test plan
firestore: released rulesstep succeeds in the run logoauthClientswrites are denied🤖 Generated with Claude Code