Skip to content

fix: running uat and writing-plans at the same time, uat not block anything (#45) - #47

Merged
ngthluu merged 2 commits into
mainfrom
ai/issue-45
Jul 25, 2026
Merged

fix: running uat and writing-plans at the same time, uat not block anything (#45)#47
ngthluu merged 2 commits into
mainfrom
ai/issue-45

Conversation

@ngthluu

@ngthluu ngthluu commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Closes #45

Automated by loope (bug flow). Spec and plan, if any, are committed in this branch under docs/.

The feature route called uat.RunFeature() inline between the committed spec
and runPlanThenExecute(), so a whole extra Claude session sat between
SPEC_READY and the plan session starting. "Non-blocking" only ever meant "a
UAT failure does not fail the pipeline" — it still blocked on wall time.

The checklist is a side errand on a spec that is already committed and nothing
downstream reads it, so it now starts on its own goroutine (UAT.StartFeature)
and the plan session runs concurrently with it. The returned wait func is
deferred, so the pipeline joins the session on every exit path: it must not
outlive the worktree and context that handleIssue tears down on return.

Claude.nextSeq now takes a mutex — two sessions share one *Claude, and they
must not race on the log sequence counter or be handed the same number.

Judgement calls made headlessly:
- Bug route left sequential: its UAT step is the last thing in the pipeline,
  so there is nothing to overlap it with. Only the feature route (the one the
  issue names) changes.
- The two order-coupled feature tests now key on prompt content instead of
  call ordinals, since call order is no longer deterministic.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
# Conflicts:
#	pipeline_feature_test.go
@ngthluu
ngthluu merged commit 251a8c6 into main Jul 25, 2026
1 check passed
@ngthluu
ngthluu deleted the ai/issue-45 branch July 25, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: running uat and writing-plans at the same time, uat not block anything

1 participant