Robber planner#28
Conversation
Completed Robber Spawn and Destination creation
Merging main into car_ai
| public Transform CustomDestination; | ||
|
|
||
| protected Transform CustomDestination; | ||
| public GameObject destinationPrefab; |
There was a problem hiding this comment.
Please note where custom destinations are expected to be coming from.
| // protected DestinationPlanner planner; | ||
|
|
||
| protected string endpoint; | ||
|
|
There was a problem hiding this comment.
Please note intended use case for Awake()
I can only really guess that it's a function that sets it to be able to move, but why is it turned off to begin with?
| move = true; | ||
| CustomDestination = Instantiate(destinationPrefab).transform; | ||
|
|
||
| // CustomDestination = Instantiate(destinationPrefab, Vector3.zero, Quaternion.identity).transform; |
There was a problem hiding this comment.
Please remove commented out code if it serves no function, and if it serves function, please note as such what the function is if it's not obvious like a debug.log.
| protected CopDestinationPlanner planner; | ||
| Rigidbody rigidbody; | ||
|
|
||
| private string endpoint = "cop"; |
There was a problem hiding this comment.
Is this variable used? it doesn't look like it?
|
|
||
|
|
||
| /* | ||
| This function returns the Vector3 position of the current robber vehicle |
There was a problem hiding this comment.
Wait, is this comment correct? The function implementation and the function name seem to imply it's getting where the robber is going?
| } | ||
|
|
||
|
|
||
| Vector3 GetFurthestNavMeshPoint(Vector3 startPos, float maxDist) |
There was a problem hiding this comment.
If this is directly attached to the robber and the robber is the only one to use this function, why have startPos and not just code in this.transform.position?
| [SerializeField] private GameObject copCarPrefab; | ||
| [SerializeField] private GameObject[] carModelPrefabChoices; | ||
|
|
||
| private void Start() { |
There was a problem hiding this comment.
Note that this, from my understanding, ensures there's exactly one object running BIntersectionManager
vpham1897
left a comment
vpham1897
left a comment
There was a problem hiding this comment.
There's a bunch of bits that should be deleted (namely use of comments to delete old code) and comments regarding helpful information I'd like, but overall looks good.
Merge changes from main into robberPlanner branch
3 participants
No description provided.