aggregate counts should be skipped, not disabled#606
Merged
Conversation
We're going to start emitting skipped tests in nextest-rs/nextest#3472. Prepare for that by aggregating counts into a `skipped` attribute. * On `<testsuite>`, `skipped` matches the llg and Jenkins junit-10 schemas as well as pytest and Maven Surefire. * The root-level `skipped` aggregate is a quick-junit extension matching the modern convention. Preserve `disabled` for googletest and prior-version compatibility.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 84.75% 85.09% +0.33%
==========================================
Files 7 7
Lines 1791 1831 +40
==========================================
+ Hits 1518 1558 +40
Misses 273 273 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're going to start emitting skipped tests in nextest-rs/nextest#3472. Prepare for that by aggregating counts into a
skippedattribute.<testsuite>,skippedmatches the llg and Jenkins junit-10 schemas as well as pytest and Maven Surefire.skippedaggregate is a quick-junit extension matching the modern convention.Preserve
disabledfor googletest and prior-version compatibility.