-
Notifications
You must be signed in to change notification settings - Fork 569
Silent call default #18909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silent call default #18909
Changes from all commits
f12a89b
064ca4e
0556927
eeab99f
efe8c1c
c5a23cd
579f83c
bc0f0eb
1865168
757e16d
8eeae6d
8ddbb8e
09df400
b3bef70
c68a4d3
17d690f
af9eea0
be4b1d5
3ddbde9
c8de3b3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -171,7 +171,7 @@ export default { | |||||
| */ | ||||||
| silentCall: { | ||||||
| type: Boolean, | ||||||
| default: false, | ||||||
| default: null, | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's better be set directly in TopBar.vue, where it's visible; but design-wise it wouldn't be nice to hold a call button with such long text.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is your suggestion here?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in spreed/src/components/TopBar/TopBar.vue Line 130 in 48ca819
and below in component: directSilentCall() {
return !this.settingsStore.showMediaSettings // only when dialog is not shown
&& this.settingsStore.defaultCallMethodIsSilent // and your new setting is on
}
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. still not needed to change default to |
||||||
| }, | ||||||
|
|
||||||
| isRecordingFromStart: { | ||||||
|
|
@@ -385,7 +385,7 @@ export default { | |||||
| async handleJoinCall() { | ||||||
| this.loading = true | ||||||
| await this.joinCall(this.token, { | ||||||
| silent: this.hasCall ? true : this.silentCall, | ||||||
| silent: this.hasCall ? true : this.silentCall !== null ? this.silentCall : false, | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also not needed
Suggested change
|
||||||
| recordingConsent: this.recordingConsentGiven, | ||||||
| shouldStartRecording: this.isRecordingFromStart, | ||||||
| }) | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -127,7 +127,7 @@ | |
| <!-- Upcoming meetings --> | ||
| <CalendarEventsDialog v-if="showCalendarEvents" :token="token" /> | ||
|
|
||
| <CallButton v-if="!isInCall" shrinkOnMobile /> | ||
| <CallButton v-if="!isInCall" :silentCall="directSilentCall" shrinkOnMobile /> | ||
|
|
||
| <!-- TopBar menu --> | ||
| <TopBarMenu | ||
|
|
@@ -167,6 +167,7 @@ import TasksCounter from './TasksCounter.vue' | |
| import TopBarMenu from './TopBarMenu.vue' | ||
| import { useGetThreadId } from '../../composables/useGetThreadId.ts' | ||
| import { useGetToken } from '../../composables/useGetToken.ts' | ||
| import { useSettingsStore } from '../../stores/settings.ts' | ||
| import { AVATAR, CONVERSATION, PARTICIPANT } from '../../constants.ts' | ||
| import { getTalkConfig, hasTalkFeature } from '../../services/CapabilitiesManager.ts' | ||
| import { useActorStore } from '../../stores/actor.ts' | ||
|
|
@@ -229,6 +230,7 @@ export default { | |
| CONVERSATION, | ||
| threadId: useGetThreadId(), | ||
| token: useGetToken(), | ||
| settingsStore: useSettingsStore(), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be conflicting now. Please lift it three lines up to other store declarations |
||
| } | ||
| }, | ||
|
|
||
|
|
@@ -318,6 +320,10 @@ export default { | |
| getUserId() { | ||
| return this.actorStore.userId | ||
| }, | ||
| directSilentCall() { | ||
| return !this.settingsStore.showMediaSettings | ||
| && this.settingsStore.defaultCallMethodIsSilent | ||
| }, | ||
| }, | ||
|
|
||
| watch: { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove that log