fix: get rid of legacy prop - #18687
Open
Antreesy wants to merge 1 commit into
Open
Conversation
Contributor
|
Before/After screenshots are mixed? |
Contributor
Author
No
That's from non-legacy --... offset variable |
Contributor
|
Then I didn't get the change. Do you want to remove |
Contributor
Author
Yes, as it's a deprecated prop that barely changing styles for us. All major changes introduce with v34 are wired with server check
For now, so we can update section by section |
Contributor
Author
|
Added a similar offset to 'legacy' sections, here's how it looks next to modern settings: |
- content non-wrapped with class 'app-settings-subsection' showed huge gaps, that are not expected with 'legacy-style' components - temporarily wrap in div until migrated Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/noid/settings-dialog-legacy
branch
from
July 17, 2026 15:09
ccf2d6b to
ba9db80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
See section names drifted off to the right, slight change in vertical gaps (in some places)
🏁 Checklist