feat(sip): treat direct-dial-in and dial-out similarly - #18569
Merged
Conversation
DorraJaouad
approved these changes
Jul 7, 2026
DorraJaouad
left a comment
DorraJaouad
left a comment
Contributor
There was a problem hiding this comment.
Good that you moved it to the util
SystemKeeper
approved these changes
Jul 7, 2026
SystemKeeper
left a comment
SystemKeeper
left a comment
Contributor
There was a problem hiding this comment.
Tested and works (besides the number conversion not being correct at #18567 (review)).
Member
|
/backport to stable34 |
Member
|
/backport to stable33 |
- When calling back from direct-dial-in conversation, it's essentially the same dial-out request. So rejecting / ending the call should work the same way, as if for dial-out room type - Extract helper util to reuse it across project Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/18122/direct-dial-in-frontend
branch
from
July 9, 2026 08:46
e40f1b9 to
7a2e9cc
Compare
Antreesy
changed the base branch from
bugfix/18123/handle-direct-incoming-calls-as-phone-participants
to
main
July 9, 2026 08:46
Contributor
Author
|
Rebased onto main to get frontend-only changes |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/18569/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7a2e9cc3
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/18569/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
OBJECT_ID.PHONE_INCOMINGwas not used before in client codeAI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist