fix(provisioning_api): let sub-admins change group memberships - #63307
Open
pringelmann wants to merge 1 commit into
Open
fix(provisioning_api): let sub-admins change group memberships#63307pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
requested review from
CarlSchwan,
icewind1991,
salmart-dev and
sorbaugh
and removed request for
a team
August 17, 2026 08:45
Contributor
Author
|
/backport to stable34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since 34 the account edit dialog sends group changes as a
groupsarray inPATCH /cloud/users/{userId}. That endpoint rejected the field for anyone who is not a full or delegated admin, so sub-admins can no longer change the groups of an existing account, not even their own. Creating an account with those groups and thePOSTendpoints have always allowed it.Sub-admins can now add and remove the groups they administer:
removeFromGroupsubadminGroupsstays admin only, and adding to theadmingroup is still full admin only.Checklist
3. to review, feature component)stable32)AI (if applicable)