Skip to content

fix: make top nav bar right elements within a nav #63239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kristian-zendato wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −8
Open

fix: make top nav bar right elements within a nav #63239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions core/css/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,21 @@
flex: 1 0;
}
}

// List wrapper for notifications / contacts / account (and injected entries)
&__items {
display: inline-flex;
align-items: center;
justify-content: flex-end;
list-style: none;
margin: 0;
padding: 0;
}

&__item {
display: flex;
align-items: center;
}
}

// Public layout related headers
Expand Down
5 changes: 3 additions & 2 deletions core/css/mobile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,16 @@
}

@media only screen and (max-width: 480px) {
#header .header-end > div > .menu {
#header .header-end .menu {

@pringelmann pringelmann Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping to a descendant selector means any nested .menu in the header matches now, not just the toggle's own. Can you do the same two-selector thing as below?

max-width: calc(100vw - 10px);
position: fixed;
&::after {
display: none !important;
}
}
/* Arrow directly child of menutoggle */
#header .header-end > div {
#header .header-end > div,
#header .header-end__item > div {
&.openedMenu {
&::after {
display: block;
Expand Down
3 changes: 2 additions & 1 deletion core/src/components/UnifiedSearch/UnifiedSearchLocalSearchBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ function clearAndCloseSearch() {
inset-inline: 0;
}
// Hide all other entries, especially the user menu as it might leak pixels
:global(.header-end:has(.local-unified-search--open) > :not(.unified-search-menu)) {

@pringelmann pringelmann Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop this? The local search bar is Deck-only and Deck already replaced it with its own filter input, so it's getting removed from the header anyway. No point patching selectors on it.

:global(.header-end:has(.local-unified-search--open) > :not(.unified-search-menu)),
:global(.header-end:has(.local-unified-search--open) .header-end__item:not(:has(.local-unified-search--open))) {
display: none;
}
}
Expand Down
18 changes: 13 additions & 5 deletions core/templates/layout.user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,19 @@
<div class="header-center">
<div id="unified-search"></div>
</div>
<div class="header-end">
<div id="notifications"></div>
<div id="contactsmenu"></div>
<div id="user-menu"></div>
</div>
<nav class="header-end" aria-label="<?php p($l->t('User menu')); ?>">

@susnux susnux Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats not the user menu, the user menu is the one on the very end.
This navigation should have a different label

Also the content within must have proper roles.

  • ul needs role = menubar
  • li needs role = none
  • button within need role = menuitem -> this needs to be fixed in NcHeaderButton

@kristian-zendato kristian-zendato Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susnux The user menu is already in nav wrapper.
As far as I checked the comment here(https://github.com/nextcloud-gmbh/customer-feature-requests/issues/1591#issuecomment-5281587123), we need to move the whole top navbar within a nav wrapper which is in div now.

@pringelmann pringelmann Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the issue though: wrapping it means nav inside nav. Fine to have the outer one, but then AccountMenu shouldn't set is-nav. And "User menu" is the wrong label for the whole bar either way.

<ul class="header-end__items">
<li class="header-end__item">
<div id="notifications"></div>
</li>
<li class="header-end__item">
<div id="contactsmenu"></div>
</li>
<li class="header-end__item">
<div id="user-menu"></div>
</li>
</ul>
</nav>
</header>

<div id="content" class="app-<?php p($_['appid']) ?>">
Expand Down
Loading