[stable34] fix: make unified filter chip accessible - #63224
Merged
Conversation
kristian-zendato
requested review from
skjnldsv,
sorbaugh and
susnux
and removed request for
a team
August 13, 2026 13:51
github-actions
Bot
changed the title
susnux
approved these changes
Aug 13, 2026
pringelmann
approved these changes
Aug 17, 2026
Contributor
|
/compile rebase |
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/unified-search-chip-accessibility
branch
from
August 17, 2026 11:21
1ad3dc2 to
ad91bf0
Compare
Contributor
|
/backport 472bb53 to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The remove control on unified search filter chips was a plain
<span>with a click handler: it was not keyboard-focusable and had no accessible name, so screen reader and keyboard users could not remove an active filter.This changes the control to a real
<button>and adds a translatedaria-label("Remove filter: {text}") so assistive technology announces which filter will be removed. Styles were adjusted so the button keeps the previous visual appearanceChecklist
3. to review, feature component)stable32)AI (if applicable)