fix(iMIP): Prevent mails from carrying an unrelated user's name - #62580
Conversation
|
/backport to stable34 |
|
/backport to stable33 |
|
/backport to stable32 |
35a2ff6 to
13acc22
Compare
|
Hey, I had a quick look and read and I think we are going to have to make this change further down in the schedule() function, there are two sending code paths, one for sending via system mail the other using mail provider (user own email address) When sending using the mail provider we use the email address that is original provided in the event to match a email account in the mail provider. So it should be: System mail -> Set display name -> Set reply to address |
|
@SebastianKrupinski I'm not sure what you mean. The display name for the mail is being set independently from this setting, before and after this PR. Could you get more into detail? |
13acc22 to
3f1e76d
Compare
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
3f1e76d to
96f04ec
Compare
|
/backport to stable31 |
|
/backport to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/62580/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 96f04ec9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62580/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/62580/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 96f04ec9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62580/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/62580/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 96f04ec9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62580/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
This PR fixes an issue in the iMIP component of Nextcloud.
When the iTip message contains no (optional)
CNproperty for the person we're sending the iMIP message on behalf of, we're using the display name of the current session user to fill out the sender for iMIP messages. This means we're sending out mails with the correct mail address, but wrong display name. Example how it's sent out right now, although it should say "A":This is especially the case when using Thunderbird, as it doesn't set the
CNproperty.To solve the issue, this PR implements the following steps:
From: "Nextcloud" <noreply...>; Reply-To: <a@test.example>Checklist
3. to review, feature component)stable32)AI (if applicable)