fix(security): reliably set Referrer-Policy: same-origin on the login page

[Narita-1095305]

• Resolves: [Bug]: Referrer-Policy for /login/ not set with .htaccess #60464

Summary

The login page relies on the security-headers block in the root .htaccess to send Referrer-Policy: same-origin (every other path gets no-referrer):

<If "%{REQUEST_URI} =~ m#/login$#">
    Header always set Referrer-Policy "same-origin"
</If>
<Else>
    Header always set Referrer-Policy "no-referrer"
</Else>

%{REQUEST_URI} inside <If> is evaluated against the post-rewrite URI. Once the front-controller rewrite installed by occ maintenance:update:htaccess is active (RewriteRule . index.php [PT,E=PATH_INFO:$1], added when htaccess.RewriteBase is set), the URI the expression sees is no longer /login, so the match fails and the request falls through to the <Else> branch — the login page ends up with Referrer-Policy: no-referrer instead of same-origin.

The same m#/login$# match also fails, independently of any rewrite, for:

• /login/ (trailing slash — the exact form in the issue title), and
• /index.php/login.

There is no PHP-layer fallback: LoginController only injects an HTML <meta name="referrer"> tag, and <Else>'s Header always set would override any header the PHP layer tried to set — so this must be fixed in .htaccess.

Fix

Match against %{THE_REQUEST} — the original request line, which is not affected by mod_rewrite — and allow an optional index.php/ prefix, an optional trailing slash, and a following query string:

<If "%{THE_REQUEST} =~ m#\s/(index\.php/)?login/?[\s?]#">

Verification

Reproduced and verified against Apache 2.4 (mod_headers + mod_rewrite) with the current .htaccess plus the front-controller rewrite (i.e. the reporter's configuration), using a backend that sets no Referrer-Policy of its own:

Request	before	after
/login	no-referrer ❌	same-origin ✅
/login/	no-referrer ❌	same-origin ✅
/login?redirect_url=…	no-referrer ❌	same-origin ✅
/index.php/login	no-referrer ❌	same-origin ✅
/settings, /apps/files, /	no-referrer ✅	no-referrer ✅
/relogin, /apps/login (no false match)	no-referrer ✅	no-referrer ✅

apachectl -t reports Syntax OK with the change.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests are included — the .htaccess/Apache header behavior is not covered by the PHP test suite (the existing SecurityHeaders setup-check only probes the heartbeat route and accepts any valid Referrer-Policy value). Verified manually against Apache as shown above; happy to add coverage if maintainers can point to a suitable harness.
• Screenshots before/after for front-end changes — n/a
• Documentation has been updated or is not required
• Backports requested where applicable — reproduces on stable branches (reported on v32/v33); can request backports if desired.
• Labels added where applicable
• Milestone added for target branch/version

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)