Skip to content

Perf/reorganize autoloading - #62231

Draft
come-nc wants to merge 15 commits into
masterfrom
perf/reorganize-autoloading
Draft

Perf/reorganize autoloading#62231
come-nc wants to merge 15 commits into
masterfrom
perf/reorganize-autoloading

Conversation

@come-nc

@come-nc come-nc commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

The idea here is to have only one autoloader instead of one by application, with a cached classmap in a PHP file.
On a test instance (debug mode on) I get 500ms instead of 600ms to run occ status.
The cached array in PHP file mechanism could be leveraged for other optimizations.

TODO

  • Fix tests if needed
  • Remove debug output
  • Remove TODO comments
  • Clean up git history
  • Rework tooling related to autoloader (build/autoloadchecker.sh notably)
  • Document
  • Rename/move new classes to a namespace
  • Add tests for new classes
  • Move core and lib to PSR4 scanning
  • Remove parts of Autoloader we do not use (leftover from nette)
  • Test updates, app installs, app upgrades…
  • Figure out how to manage temp directory (default location, opcache config, deletion of old files, permissions, and so on)
  • Improve installation usecase (currently results in 26 disk scans because each app installation triggers one, and 26 files in cache afterwards)
  • Avoid having to compute namespaces from enabled apps, directly cache autoloading and namespaces. Maybe appinfo as well?

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@come-nc come-nc self-assigned this Jul 16, 2026
github-advanced-security[bot]
github-advanced-security AI found potential problems Jul 16, 2026
View reviewed changes
Comment thread lib/private/Autoloader.php Fixed
Comment thread lib/private/Autoloader.php Fixed
@icewind1991

icewind1991 commented Jul 16, 2026

Copy link
Copy Markdown
Member

(I'm very hesitant about this approach but don't really know how to formulate my reasoning, but leaving a note for a soft-disagreement until I can better word things or change my mind)

@come-nc

come-nc commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

(I'm very hesitant about this approach but don't really know how to formulate my reasoning, but leaving a note for a soft-disagreement until I can better word things or change my mind)

Is your disagreement with the PhpDumpCache API or the autoloader change?
I’m willing to work on both aspects but I think we cannot avoid rethinking the autoloader to use a maintained classmap at some point, it’s too much of a performance boost.

I did the PhpDumpCache part that way because I would like to re-use it for other things, notably caching commands as in this draft: #61865
And PHP on-disk is the fastest cache you can get, it ends up in the opcache.

come-nc added 11 commits August 13, 2026 14:39
@come-nc
feat: Add a PhpDumpCache service for caching arrays as PHP files
bba4efa 
This leverages opcache to be as fast as possible. Can be used for
 autoloading class maps, but also for other kind of pre-computed cached
 arrays (routes, occ commands, …).

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
feat: Use a custom autoloader instead of composer
bfb3bd5 
The idea is to cache to disk a static classmap with all classes from
 core and applications.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
perf: Move registerAutoloading to AppManager and optimize
5b89f3a 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Re-enable composer autoloader from apps for backward compatibility
bcbead0 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
perf: Delete composer autoloader for shipped apps to rely on the new one
b96c44e 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Use Psr4 for OC/OCP, make cache directory configurable
af3e0c8 
cachedirectory still needs to be added to config.sample.php

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Fix autoloading of test classes
91043e6 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Hardcode require of functions file that autoloader cannot load
19a3416 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Harmonize namepsaces in tests
b07461f 
There was a weird inconsistent mix of Test\, Tests\lib, Test\Core,
 Tests\Core and Core\.
Now there is only Test\ for tests/lib/ and Tests\Core for tests/Core.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Explicitely use OC AppManager when calling internal method
435f093 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix(autoloader): Remove now-unused non-psr4 directory scan
b688559 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-nc force-pushed the perf/reorganize-autoloading branch from cdca333 to b688559 Compare August 13, 2026 12:39
come-nc added 4 commits August 13, 2026 14:58
@come-nc
chore(autoloader): Avoid having to trim on adding an autoloading path
916e3ca 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Remove unused file scanning and autorebuild from Autoloader
6239c3f 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
feat: Cache application states and autoloading directly from AppManager
80f5d99 
Avoids parsing info.xml from each app and recomputing namespaces. For
 now Autoloader still has its own calls to PhpDumpCache which is a bit
 dirty, we might want to clean that up later.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
feat: Use PhpDumpCache in Console/Application to avoid loading all co…
d1d3cd8 
…mmmands

This saves 100ms on occ runs by avoiding to load all commands to only
 run one of them. The list of commands is cached and loading is skipped
 when command is known.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst will be requested when the pull request is marked ready for review ChristophWurst is a code owner
@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala will be requested when the pull request is marked ready for review miaulalala is a code owner
@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen will be requested when the pull request is marked ready for review nickvergessen is a code owner
1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@come-nc come-nc

Labels

2. developing Work in progress performance 🚀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@come-nc @icewind1991 @github-advanced-security