Skip to content

fix(files): uri encode node source #61494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leftybournes wants to merge 1 commit into from
Closed

fix(files): uri encode node source #61494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/files/src/store/files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export const useFilesStore = defineStore('files', () => {
*/
function deleteNodes(nodes: INode[]) {
const entries = Object.entries(files.value)
.filter(([, node]) => !nodes.some((n) => n.source === node.source))
.filter(([, node]) => !nodes.some((n) => n.source === encodeURI(node.source)))

@susnux susnux Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should there be ever a case of uri-encoded source? The source has to be not URI encoded.

If you need the URI encoded source, use node.encodedSource.

IF there are cases with URI encoded source, then those cases need to be fixed.

@leftybournes leftybournes Aug 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, it was viewer adding the URI encoded source. I opened a PR for it: nextcloud/viewer#3320

files.value = Object.fromEntries(entries)
}

Expand Down
Loading