todo: update to v33#372
Draft
otherwiseGG wants to merge 8 commits into
Draft
Conversation
Agent-Logs-Url: https://github.com/otherwiseGG/documentserver_community/sessions/7c4d7ee5-24dc-4f97-a058-3c0b9f52b630 Co-authored-by: otherwiseGG <77602833+otherwiseGG@users.noreply.github.com>
…n-version Normalize document route paths to avoid malformed conversion URLs
Agent-Logs-Url: https://github.com/otherwiseGG/documentserver_community/sessions/1e1c13d6-7adb-4c3f-b2df-b68c89533399 Co-authored-by: otherwiseGG <77602833+otherwiseGG@users.noreply.github.com>
…eter Fix Nextcloud 33 DB compatibility and limit community auto-config to supported editor formats
There was a problem hiding this comment.
Pull request overview
This PR begins the migration of the documentserver_community app toward Nextcloud v33 compatibility by introducing a DB query compatibility layer and updating several persistence layers to use it, alongside adjustments to ONLYOFFICE auto-configuration and document file route handling.
Changes:
- Add
DB\QueryHelperto abstractexecuteQuery/executeStatement(v33+) vs legacyexecute()usage, and migrate session/change/lock/IPC DB access to it. - Update
SessionManagerto accept anIIPCFactoryand clean up IPC channels when expiring sessions. - Restrict/normalize ONLYOFFICE community document server auto-config formats and normalize generated
documentFilepaths.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Channel/SessionManagerTest.php | Updates test setup/teardown for new SessionManager constructor and query execution helper. |
| lib/OnlyOffice/AutoConfig.php | Adds supported-format filtering and sync behavior for community document server installs. |
| lib/IPC/DatabaseIPCBackend.php | Switches DB operations to QueryHelper for v33 query API compatibility. |
| lib/Document/LockStore.php | Switches lock persistence queries to QueryHelper. |
| lib/Document/ChangeStore.php | Switches change persistence queries to QueryHelper and handles MAX() returning null. |
| lib/DB/QueryHelper.php | Introduces the compatibility helper for query execution and fetching across Nextcloud versions. |
| lib/Controller/DocumentController.php | Normalizes incoming file paths to be relative (strips leading /). |
| lib/Controller/ConvertController.php | Generates relative path values for documentFile route usage. |
| lib/Channel/SessionManager.php | Migrates queries to QueryHelper and injects IIPCFactory for channel cleanup on session expiry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/otherwiseGG/documentserver_community/sessions/721d3a3d-e0fb-486f-ab2f-f0e98c8762ae Co-authored-by: otherwiseGG <77602833+otherwiseGG@users.noreply.github.com>
…elogs Align controller endpoint annotations with Nextcloud v33 attribute requirements
Agent-Logs-Url: https://github.com/otherwiseGG/documentserver_community/sessions/8749dd43-bd3a-4020-8f2f-6449ef51a2f7 Co-authored-by: otherwiseGG <77602833+otherwiseGG@users.noreply.github.com>
…-options Normalize controller responses and preserve PDF default format in v33
Author
|
In the current Version, we're able to get basic Functionalities back without Complaining. We are currently trying to get PDF Read & Edit back on track. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya! I started working on moving this project over to v33. This is some beginning that makes the Plugin comaptible with the recent changes in v33. There are however still alot of issues with it, but atleast it doesnt complain anymore.
Nextcloud 33 query API compatibility
Add a small query helper that abstracts executeQuery / executeStatement vs legacy execute().
Update session, change, lock, and IPC storage paths to use the compatibility layer instead of direct deprecated calls.
Supported format auto-configuration
Restrict community auto-configuration to the format set supported by the bundled document server.
Preserve ONLYOFFICE’s discovered format matrix, but filter default/editable selections to known-safe extensions.
Re-sync existing community-document-server installs when unsupported formats are currently enabled, preventing invalid documentType configs from being generated.