fix(contacts): correctly insert contacts into sorted list - #5626
Open
triantos wants to merge 1 commit into
Open
Conversation
triantos
requested review from
GVodyanov,
SebastianKrupinski and
hamza221
as code owners
August 8, 2026 01:58
Use the existing favorite-and-name comparator to find the insertion point and cover beginning, middle, end, and favorite ordering. Assisted-by: Codex:gpt-5 Signed-off-by: Nick Triantos <nick@triantos.com>
triantos
force-pushed
the
fix/contact-sorted-insertion
branch
from
August 8, 2026 01:58
04769bb to
8c22afe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The previous insertion loop could omit a newly created contact from
sortedContactswhen it sorted before every existing entry. It could also place contacts incorrectly in the middle or across favorite boundaries. Because the new contact was absent from the sorted list, navigation could immediately report “Contact not found” after creating it.Tests
npm test -- --runInBand(29 tests pass)npm run lint -- --quietnpm run build