feat(principal): map CalDAV room metadata properties - #8693
Merged
Conversation
odzhychko
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
August 7, 2026 09:27
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4 tasks
Comment on lines
+25
to
+33
| export interface RoomPrincipalProperties { | ||
| roomType: string | null | ||
| roomSeatingCapacity: number | null | ||
| roomBuildingAddress: string | null | ||
| roomBuildingStory: string | null | ||
| roomBuildingRoomNumber: string | null | ||
| roomFeatures: string[] | null | ||
| roomAddress: string | null | ||
| } |
Contributor
There was a problem hiding this comment.
Can we put all the interface in a types file please... "src/types/"
| /** | ||
| * Properties shared between all principal types. | ||
| */ | ||
| export interface SharedPrincipalProperties { |
Contributor
There was a problem hiding this comment.
Can we call this something like "BasePrincipalProperties" istead of "Shared", at first I through this had something to do with sharing until I read the doc
odzhychko
enabled auto-merge (squash)
August 7, 2026 18:34
odzhychko
added
3. to review
Co-authored-by: Rik Dekker <rik@rikdekker.nl> Assisted-by: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
odzhychko
force-pushed
the
feature/room-metadata-v2
branch
from
August 7, 2026 18:38
8d8e3f3 to
9cb8129
Compare
SebastianKrupinski
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make room metadata available on principle objects (e.g. returned by
@/models/principal.js)This implementation breaks with a few of the established patterns in
@/modelsanticipating ongoing push for type-safety/ TypeScript:RoomPrincipaltypeThis PR just adapts what was build in #8263 to align with how we want to extend our models in the future.
@Rikdekker Thank you very much. Here is a summary of things I decide to do differently compared to #8263:
undefinedif is not aRoomPrincipalnullis now reserved for when it is aRoomPrincipaland a value was not provided or had an unexpected valueroomSeatingCapacityandroomFeaturesroomBuildingNameRoomPrincipalobjectroomBuildingStoryroomAddressdirectly from the cdav-library objectroomBuildingRoomNumberinstead ofroomNumber🤖 AI (if applicable)